[BUGFIX] Fix maxitems count by correcting version state check#186
Open
gmartino27 wants to merge 1 commit into
Open
[BUGFIX] Fix maxitems count by correcting version state check#186gmartino27 wants to merge 1 commit into
gmartino27 wants to merge 1 commit into
Conversation
(cherry picked from commit 85a6ce2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
maxitemscounting logic inContentRepositoryby correcting theVersionStatecomparison used while iterating workspace-overlaidtt_contentrows.The previous condition could evaluate incorrectly and include records that should be ignored (for example delete placeholders), which leads to wrong item counts for a column and can affect
maxitemsenforcement.Change
VersionStatecheck in:Classes/Repository/ContentRepository.phpThis is an intentionally minimal fix (single logical correction) and does not change public configuration or behavior outside the faulty counting condition.