Modernize code #26
Open
Modernize code #26
+71
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan-Schuppik
previously approved these changes
Dec 10, 2025
sukhwinder33445
approved these changes
Dec 10, 2025
Jan-Schuppik
approved these changes
Dec 11, 2025
Adjust docstring
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
0423869 to
9816678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing return , parameter and property types.
This includes implementations of
ipl\Stdlib\Contract\Translator, so this branch must be merged together with Icinga/ipl-stdlib/pull/63. This is also the reason for the failing unit tests.