Add php 8.5 support #61
Open
+6
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
support-php-85
branch
from
4322c75 to
7354db6
Compare
Errors like: - Deprecated: ipl\Stdlib\Str::trimSplit(): Implicitly marking parameter $limit as nullable is deprecated, the explicit nullable type must be used instead
sukhwinder33445
force-pushed
the
support-php-85
branch
from
52f1357 to
415ad2b
Compare
sukhwinder33445
force-pushed
the
support-php-85
branch
from
2fc2357 to
ff553e0
Compare
BastianLedererIcinga
previously approved these changes
Dec 10, 2025
`scanDirectories` was set to `/usr/share/icinga-php` to simplify local testing, as both the Icinga PHP Library and Icinga PHP Thirdparty are installed there in our development environment. Our individual PHP library components, which make up these libraries, are self-contained, as they define all necessary dependencies themselves. This then requires testing with exactly these dependencies instead of an arbitrary folder that could contain anything, e.g., dependencies in unexpected versions or dependencies that have not yet been defined. For remote and local testing, `composer install` must be executed and tests must be performed with exactly the resulting dependencies. Since PHPStan uses the Composer autoloader by default, if available, `scanDirectories` does not need to be defined at all. - #62 makes it superfluous for github actions
PhpUnit Test:
```
- 1 test triggered 2 PHP warnings:
1) /home/runner/work/ipl-stdlib/ipl-stdlib/src/Filter.php:540
Undefined property: stdClass::$foo
Triggered by:
* ipl\Tests\Stdlib\FilterTest::testConditionsHandleMissingColumnsProperly (6 times)
/home/runner/work/ipl-stdlib/ipl-stdlib/tests/FilterTest.php:624
...
```
sukhwinder33445
force-pushed
the
support-php-85
branch
from
8ce944b to
6408fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #60