EGLSharedSurface implements the SupportCSpaces method #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://phabricator.services.mozilla.com/D207651 a new feature to manage color spaces has been added. As a result, a new virtual method has been defined in the SharedSurface abstract class to indicate whether the implementor supports specific color spaces passed through the creation options. The implementation considered false as default, so that that all the surfaces implemented in the derived classes would use gfx::ColorSpace2::Display when creating the specific SharedSurface instance. This generic color space would then be determined by the new feature mentioned before, as part of the logic of the WebGLContext::PresentInto function. However, this change had the (unexpected ?) effect of disabling polling on the SwapChain::Acquire method. The problem is that no matter what color space we pass to the Acquire method, the surface created will have Display. Hence, there won't be a match with the pool's front so that it's set to an empty set. We are not sure yet whether this is such an expected behavior of the new color management feature, but it's worth filing a bug upstream so that Mozilla folks can evaluate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://phabricator.services.mozilla.com/D207651 a new feature to manage color spaces has been added. As a result, a new virtual method has been defined in the SharedSurface abstract class to indicate whether the implementor supports specific color spaces passed through the creation options.
The implementation considered false as default, so that that all the surfaces implemented in the derived classes would use gfx::ColorSpace2::Display when creating the specific SharedSurface instance. This generic color space would then be determined by the new feature mentioned before, as part of the logic of the WebGLContext::PresentInto function.
However, this change had the (unexpected ?) effect of disabling polling on the SwapChain::Acquire method. The problem is that no matter what color space we pass to the Acquire method, the surface created will have Display. Hence, there won't be a match with the pool's front so that it's set to an empty set.
We are not sure yet whether this is such an expected behavior of the new color management feature, but it's worth filing a bug upstream so that Mozilla folks can evaluate it.