-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to can docs #3
Conversation
Add more commands and fix some errors in docs
Add to can docs
@anfroholic Hi Andrew. Thank you very much.
Thanks, Ihor |
No problem, thanks for your work.
This branch? (pr/5310), sorry I am not very fluent with github.
Sure. I think I can do that. I haven't seen this document before https://github.com/IhorNehrutsa/micropython/blob/pr/5310/docs/library/machine.CAN.rst and will mark it up to date.
I am working on something a little different, so that is not what I'm looking for. I'd be happy to offer my opinion on anything if you'd like to hear it. Thanks again |
Please work(comment) with the Quickrefs are Library helps are |
asan considers that memcmp(p, q, N) is permitted to access N bytes at each of p and q, even for values of p and q that have a difference earlier. Accessing additional values is frequently done in practice, reading 4 or more bytes from each input at a time for efficiency, so when completing "non_exist<TAB>" in the repl, this causes a diagnostic: ==16938==ERROR: AddressSanitizer: global-buffer-overflow on address 0x555555cd8dc8 at pc 0x7ffff726457b bp 0x7fffffffda20 sp 0x7fff READ of size 9 at 0x555555cd8dc8 thread T0 #0 0x7ffff726457a (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xb857a) #1 0x555555b0e82a in mp_repl_autocomplete ../../py/repl.c:301 #2 0x555555c89585 in readline_process_char ../../lib/mp-readline/re #3 0x555555c8ac6e in readline ../../lib/mp-readline/readline.c:513 #4 0x555555b8dcbd in do_repl /home/jepler/src/micropython/ports/uni #5 0x555555b90859 in main_ /home/jepler/src/micropython/ports/unix/ #6 0x555555b90a3a in main /home/jepler/src/micropython/ports/unix/m #7 0x7ffff619a09a in __libc_start_main ../csu/libc-start.c:308 micropython#8 0x55555595fd69 in _start (/home/jepler/src/micropython/ports/uni 0x555555cd8dc8 is located 0 bytes to the right of global variable 'import_str' defined in '../../py/repl.c:285:23' (0x555555cd8dc0) of size 8 'import_str' is ascii string 'import ' Signed-off-by: Jeff Epler <[email protected]>
Hi IhorNehrutsa,
Thanks for your work adding to the can code base. I recently compiled your fork and it seems to be working great. I'd love to help out. I have a fair amount of experience with the can functionality of the stm32 version.
Let me know what your goals are and I will do what I can.
Thanks
Andrew