feat: add --feedback flag for search result quality feedback loop (#604) - #611
Open
lb1192176991-lab wants to merge 1 commit into
Open
feat: add --feedback flag for search result quality feedback loop (#604)#611lb1192176991-lab wants to merge 1 commit into
lb1192176991-lab wants to merge 1 commit into
Conversation
- Add --feedback flag to search_knowledge.py - After displaying results, prompt: 'Was this helpful? (y/n/c=comment)' - Log feedback to data/search-feedback.jsonl - No PII in logs (only query + result info + feedback) - No external dependencies - Existing search behavior unchanged when --feedback not used Closes Ikalus1988#604
Ikalus1988
added
needs-dco
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
--feedbackflag tosearch_knowledge.pyso users/agents can report whether search results were useful.Was this helpful? (y/n/c=comment/Enter=skip)data/search-feedback.jsonlwith: query, found_results, feedback, timestampWhy
This feeds into #574 (feedback hub) and #591 (demand board) — enabling systematic tracking of search result quality and identification of knowledge gaps.
Testing
data/search-feedback.jsonlcontains valid JSONL entries--feedbacknot used