Hole found in mirror stream #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This clear should be present irrespective of whether consumerCommitPaths is empty or not.
There was a problem hiding this comment.
parameter name being used for tobeCommittedPaths and argument name doesn't match here...please fix to ensure code readability
|
Please test the following scenario
|
There was a problem hiding this comment.
Does not need to return any path.
|
Changes look good to me. |
There was a problem hiding this comment.
Can you add some documentation stating what each Path means..
i was wondering may be we should have SourcePath and DestinationPath classes abtracting out this..but we can do that later...just some docum around this would be helpful...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.