-
Notifications
You must be signed in to change notification settings - Fork 44
Added Support for InMobi SDK 10.8.0 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
InMobiSdk.init(this, "1234567890qwerty0987654321qwerty12345", consent, new SdkInitializationListener() { | ||
InMobiSdk.init(this, "1234567890qwerty0987654321qwerty1234", consent, new SdkInitializationListener() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be replaced with test placement's account Id?
InMobi Monetization SDK ChangeLog for Android | ||
============================================= | ||
|
||
## Build 10.7.7 [30/Aug/2024] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's attach the website link of SDK changelogs(https://support.inmobi.com/monetize/sdk-documentation/android-guidelines/changelogs-android), instead of updating here to avoid the manual and repetitive task.
May be remove this file and attach the changelogs link in README
Log.d(TAG, "onAdImpression"); | ||
} | ||
}); | ||
mInterstitialAd.show(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved the show from here to click of the button. Show gets called before load success otherwise
No description provided.