Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Physics sim #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

FlameKnight137
Copy link

@FlameKnight137 FlameKnight137 commented Sep 29, 2020

Closes #2

@sagarreddypatil sagarreddypatil linked an issue Sep 29, 2020 that may be closed by this pull request
@sagarreddypatil sagarreddypatil changed the title Feature/physics sim WIP: Physics sim Oct 5, 2020
Copy link
Contributor

@sagarreddypatil sagarreddypatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to do the following things

  1. Add option to change the properties of any object by clicking on it
    • All objects should have the option to change static and dynamic friction
    • Dynamic objects(such as the cube) should have the option to change the mass, in addition to static and dynamic friction
  2. Give the scenes simpler names. "Physics Basic Simulation InVisionAR" can be changed to "Basic Physics Simulation"
  3. Use a plane instead of the terrain object.
  4. Organize all assets into their respective folders(Physic materials go to the Physic Materials folder, etc.)
  5. Delete all unnecessary assets(NewLayer, Terrain, anything that isn't being used.

I don't get why you still haven't done the object editing yet. That is one of the basic requirements for this task.

@sagarreddypatil
Copy link
Contributor

Also, there was literally absolutely no reason to close the pull request. Please don't close a PR unless you are told to do so.

@FlameKnight137
Copy link
Author

Sorry about that. Also, just to make it clear for you, I did have a section for the physics material where you can edit the mass, static friction. etc. if you click on the object and click the respective physics material to change it. Also, I have updated these values already with the recent push so please check that. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create basic Physics simulation
2 participants