Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): document shading cloud, parameters flag and more #46

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

broccolai
Copy link
Member

@broccolai broccolai commented Aug 13, 2024

@broccolai broccolai marked this pull request as ready for review August 17, 2024 19:59
@broccolai broccolai changed the title feat(core): document shading cloud and some notes about versions feat(core): document shading cloud, parameters flag and more Aug 22, 2024
@broccolai
Copy link
Member Author

maven / groovy in the parameters example needs to be checked

main.py Outdated
<execution>
<phase>package</phase>
<goals>
<goal>shade</goal>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nitpick but there's some missing indentation here

docs/core/index.md Outdated Show resolved Hide resolved
Copy link
Member

@jpenilla jpenilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention the need for mergeServiceFiles() with shadow and the maven equivalent, without it the provided ParserContributors and BrigadierMappingContributors will not work with relocations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants