Pull request #2
Open
Pull request #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix integration tests. * wip * wip
2.1.0 restores the ability for TCA AppKit apps to access the `observe` function.
* Allow an alert to present another alert When we added support for vanilla SwiftUI modifiers, we lost the ability to present one alert after another because `nil` writes to the alert bindings unconditionally dismissed the feature, even if the feature was freshly presented. This fixes things by suppressing dismissal when the identity of a presented item has changed. Fix #3272. * wip
* `@preconcurrency @MainActor` isolation of `Store` * Remove unneeded `@MainActor`s * Remove thread checking code * Remove unneeded `@MainActor`s * Swift 5.10 compatibility fixes * wip * More 5.10 fixes * wip * fixes * wip * wip * up the timeout * wip * Fixes * Remove mainActorASAP in favor of mainActorNow. (#3288) * wip * Run swift-format * Update README.md * Fix integration tests. (#3294) * Fix integration tests. * wip * wip * Run swift-format * mainActorNow doesnt need escaping closure * wip * migration guide * wip * Update MigratingTo1.14.md --------- Co-authored-by: Brandon Williams <[email protected]> Co-authored-by: Brandon Williams <[email protected]> Co-authored-by: mbrandonw <[email protected]>
* `@preconcurrency @MainActor` isolation of `Store` * Remove unneeded `@MainActor`s * Remove thread checking code * Remove unneeded `@MainActor`s * Swift 5.10 compatibility fixes * wip * More 5.10 fixes * wip * fixes * wip * wip * up the timeout * wip * Fixes * wip * wip * wip * wip * wip * wip * Main actor logger * wip * wip * wip * fix * fix * fix * fix compilation error * wip * wip * bring back yield --------- Co-authored-by: Brandon Williams <[email protected]>
Now that we've locked to Swift Navigation >=2.2, we get this method for free.
* fix Typo * delete deprecated content
* `@preconcurrency @MainActor` isolation of `Store` * Remove unneeded `@MainActor`s * Remove thread checking code * Remove unneeded `@MainActor`s * Swift 5.10 compatibility fixes * wip * More 5.10 fixes * wip * fixes * wip * wip * up the timeout * wip * Fixes * wip * wip * wip * wip * wip * Fix binding action sendability * Address more binding action sendability * more bindable action sendability * more bindable action warnings * fix --------- Co-authored-by: Brandon Williams <[email protected]>
* Require sendable IDs in cancellation/reducers Many of our APIs warn that we are passing hashable identifiers across concurrency boundaries, so we should require that they're sendable. * fix * fix * Fix
* `@preconcurrency @MainActor` isolation of `Store` * Remove unneeded `@MainActor`s * Remove thread checking code * Remove unneeded `@MainActor`s * Swift 5.10 compatibility fixes * wip * More 5.10 fixes * wip * fixes * wip * wip * up the timeout * wip * Fixes * wip * wip * wip * wip * wip * Fix binding action sendability * Address more binding action sendability * more bindable action sendability * more bindable action warnings * fix * Make `Effect.map` sendable * Make `Effect.actions` sendable Also moves it to the test target, since it's only really used there. * Make `AnyPublisher.create` sendable * Make `_SynthesizedConformance` sendable * Avoid non-sendable captures of `self` in reducers We can capture the sendable case path instead. * Make `ViewStore.yield` sendable * Address internal sendability warning * fix * Another small warning --------- Co-authored-by: Brandon Williams <[email protected]>
* Address effect cancellation sendability * fix * wip * wip
* Address `Reducer._printChanges()` sendability Because printing is done on a queue, both `State` and `Action` must be sendable. While `State` is easy enough to make sendable, it might be a pain to do so in a large, modularized application. Actions are not always so easy, but are in simple cases. Alternately, since this is a debugging affordance: 1. We could forego sendability since all we're doing is hitting it with a `Mirror` at the end of the day, and traffic the state/action along in a `nonisolated(unsafe)`. 2. We could ditch the queue...but that could affect the performance pretty negatively in some cases. * Unchecked send the debug printing
* Require main actor isolation in store collection * `preconditionIsolated` is not available in iOS <14 * Update Sources/ComposableArchitecture/Observation/IdentifiedArray+Observation.swift
…rray (#3346) * Added failing test to document behavior with observation and identified array. * Update Tests/ComposableArchitectureTests/ObservableTests.swift --------- Co-authored-by: Stephen Celis <[email protected]>
* Update 05-HigherOrderReducers CaseStudies * Replace alert(store:) to alert(_:) * View clean up. * Fixed alert. * Update DownloadComponent.swift --------- Co-authored-by: Brandon Williams <[email protected]> Co-authored-by: Stephen Celis <[email protected]>
Co-authored-by: Stephen Celis <[email protected]>
* Failing test for multiple mutations to file storage. * wip * wip * fixes * wip --------- Co-authored-by: Stephen Celis <[email protected]>
* Add crashing unit test for AppStorageKey subscription cancellation * Fix double cancellation of Shared.Subscription
* Add a test to document how 'task tree' cancellation happens. * fix
* Add migration guide for 1.16. * Update README.md --------- Co-authored-by: Stephen Celis <[email protected]>
* wip * wip * remove old case study for shared notifications * wip * wip * wip * wip * wip * 1.17 migration guide * basics migration guide * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip --------- Co-authored-by: Brandon Williams <[email protected]>
…n the example case. (#3508) * fix infinite loop issue when WebSocket receives an error message * catch the error * syntax update
* Limit test case availability when using TestClock * Use withLock with shared state * Fix unit tests on iOS 16 and earlier * Fix DEBUG-mode perception check test to cover iOS 17+ * Run iOS & macOS unit tests on Xcode 16.0
…3528) * Don't report unasserted shared changes in `Reducer._printChanges()` * fix * wip * wip * wip
* Bump Sharing requirement to include 2.0.0 * Add migration guide * wip * wip * wip * wip * wip * wip * wip * wip
Fix formatting by removing extra space before 'public'.
…nts (#3568) * Fix tutorial documentation typo: sync ups to contacts * Update tutorial documentation: Use .foregroundStyle for icon color to replace deprecated .foregroundColor * Update tutorial documentation: Clarify that Reducer() is a macro * Update tutorial documentation: Modify test code to use `.modify` for enum mutation to fix issue reported in #3158 * Update tutorial documentation: Add @CasePathable to Alert enum and simplify test case syntax * Add @CasePathable to Alert enum in tutorial documentation to be consistent with previous part of the tutorial * Update tutorial documentation: Simplify StackAction with StackActionOf typealias * Update Sources/ComposableArchitecture/Documentation.docc/Tutorials/MeetTheComposableArchitecture/02-Navigation/04-NavigationStacks/02-04-NavigationStacks.tutorial --------- Co-authored-by: Stephen Celis <[email protected]>
* Update ThemePicker to use foregroundStyle instead of deprecated foregroundColor * Fix typos in tutorial documentation Corrected minor grammatical and spelling errors in SyncUpForm and TestingSyncUpForm tutorial files * Remove duplicate TestStore initialization in tutorial code * Update tutorial documentation to use non-exhaustive testing method Corrected the wording in the tutorial step description for testing the "Add sync-up" flow to specify a non-exhaustive testing approach * Update Sources/ComposableArchitecture/Documentation.docc/Tutorials/BuildingSyncUps/04-PresentingSyncUpForm/TestingSyncUpFormPresentation.tutorial --------- Co-authored-by: Stephen Celis <[email protected]>
* SyncUps speech recogonizer preview * Update Examples/SyncUps/SyncUps/Dependencies/SpeechRecognizer.swift --------- Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.