Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desmakers 2827 enable kit xmc14 2go into arduino ide #259

Conversation

jaenrig-ifx
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

@LinjingZhang LinjingZhang force-pushed the DESMAKERS-2827-enable-kit_xmc14_2go-into-arduino-ide branch from 9248c46 to 843c1a5 Compare November 30, 2023 13:16
Copy link
Member Author

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding cloning the repository for xmc-for-arduino core develentopment:
This can be added to the wiki section as information for developers.

Regarding the JLink path:
That should work if JLink is added to the system path.
We better add such requirements to the README.md installation.
For the end-user, the tools/xmc-flasher.py tool should be transparent.

@@ -149,7 +158,7 @@ jobs:
platforms: |
# Use Boards Manager to install the latest release of the platform to get the toolchain.
- name: Infineon:xmc
source-url: https://github.com/Infineon/XMC-for-Arduino/releases/latest/download/package_infineon_index.json
source-url: https://github.com/LinjingZhang/XMC-for-Arduino/releases/download/2.2.1/package_infineon_index_linjing_test.json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work because you are renaming the .json file.
As the preference configuration is meant to use "package_infineon_index.json" your file would not be find any board. You can give it a try to change that file name in your releases and update then correrspondingly the yml file.
Basically, only the repo owner in the url should be changed : "Infineon" for "LinjingZhang" if you upload the modified json to your latest release in your fork.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow error solved:

  1. Change index.json file name
  2. Manual adapt files for release
  3. For arduino/compile-sketches@v1, disable 'enable-deltas-report'
  4. Some test is not compatible (e.g. stackMem, linker script changed)

@jaenrig-ifx jaenrig-ifx self-assigned this Dec 11, 2023
@LinjingZhang
Copy link
Contributor

LinjingZhang commented Dec 13, 2023

Regarding cloning the repository for xmc-for-arduino core develentopment: This can be added to the wiki section as information for developers.

Regarding the JLink path: That should work if JLink is added to the system path. We better add such requirements to the README.md installation. For the end-user, the tools/xmc-flasher.py tool should be transparent.

wiki section update:
I will definitely add more documentation for developers.

JLink path:
the xmc-flasher can not find the JLink.exe on windows even add it to system path. It will be fixed before release.

@jaenrig-ifx
Copy link
Member Author

Everything is green :) Well done @LinjingZhang !

@jaenrig-ifx
Copy link
Member Author

Regarding cloning the repository for xmc-for-arduino core develentopment: This can be added to the wiki section as information for developers.
Regarding the JLink path: That should work if JLink is added to the system path. We better add such requirements to the README.md installation. For the end-user, the tools/xmc-flasher.py tool should be transparent.

wiki section update: I will definitely add more documentation for developers.

JLink path: the xmc-flasher can not find the JLink.exe on windows even add it to system path. It will be fixed before release.

Okay, perfect! Then remove the README_IFX.md. You can copy already that info in some page in the wiki. Then we can close this issue.

@LinjingZhang LinjingZhang changed the base branch from master to develop December 15, 2023 14:55
@LinjingZhang LinjingZhang changed the base branch from develop to master December 15, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants