Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESMAKERS-3812 Test CAN on XMC1400 2GO #283

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

LinjingZhang
Copy link
Contributor

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Test XMC1400 2go CAN functionality, fix problem

Related Issue
DESMAKERS-3812

Context
Now examples of CAN works also on new XMC1400 2GO

update compile sketches to 1.1.1
@LinjingZhang
Copy link
Contributor Author

update compile-sketches action to v1.1.1 make compilation test running

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
Minor criteria on the CAN specific implementation :)
While there is no test automation, please be sure that manually at least you validate the sunny side cases of CAN init, read/write, deinit, etc with most relevant configurations.

@LinjingZhang LinjingZhang merged commit aec9b0c into Infineon:feature/can_bus Jun 28, 2024
8 checks passed
Copy link
Member

@OlafFilies OlafFilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me but I can also yet not test it on hardware so you have to be sure that it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants