Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select: option selection and search not working as expected #1680

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

tishoyanchev
Copy link
Contributor

@tishoyanchev tishoyanchev commented Jan 15, 2025

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

  • update count after persistentSelectedOptions array updates to make sure all options get selected even when duplicate exists. This resolves bug 1.
  • Added filtering logic inside collectSelectedOptions to prevent duplicates from being displayed on load time. This resolves bug 3
  • Reassign the loadedOptions to filteredOptions inside handleDocumentClick. This resolves bug 2.

Issue reference: #1603

📦 Published PR as canary version: 30.10.0--canary.1680.e37294a413e39f8d2701149f49bc70ea9487f1e6.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@30.10.0--canary.1680.e37294a413e39f8d2701149f49bc70ea9487f1e6.0
# or 
yarn add @infineon/infineon-design-system-stencil@30.10.0--canary.1680.e37294a413e39f8d2701149f49bc70ea9487f1e6.0

Copy link
Contributor

github-actions bot commented Jan 15, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://Infineon.github.io/infineon-design-system-stencil/pr-preview-angular-example/pr-1680/

Built to branch gh-pages at 2025-01-15 15:16 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Contributor

--STORYBOOK-PREVIEW--

@tishoyanchev tishoyanchev self-assigned this Jan 15, 2025
@tishoyanchev tishoyanchev added the minor minor version bump label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-select: option selection and search not working as expected
1 participant