Skip to content

add_test#1

Closed
Shl1015CS wants to merge 5 commits intoInfiniTensor:mainfrom
Shl1015CS:main
Closed

add_test#1
Shl1015CS wants to merge 5 commits intoInfiniTensor:mainfrom
Shl1015CS:main

Conversation

@Shl1015CS
Copy link
Contributor

No description provided.

@Shl1015CS Shl1015CS marked this pull request as ready for review April 29, 2025 19:06
@Shl1015CS
Copy link
Contributor Author

提交合并

@YdrMaster YdrMaster requested a review from Simon25772 May 6, 2025 06:46
@YdrMaster YdrMaster self-assigned this May 6, 2025
Copy link
Collaborator

@Simon25772 Simon25772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件末需要留一个空行,可以使用vscode的自动格式化功能,参照https://icn8oz7pxzoz.feishu.cn/wiki/G6ZTwuARjiGZqSkWeV6co5ojnJZ
的格式规范指南一节

//! 为一些基本类型和常用类型提供预定义布局。
//! Predefined layouts for basic and commonly used types.

#![allow(missing_docs)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码中出现的所有 [allow(...)] 须通过注释说明理由

@@ -12,4 +12,111 @@
![GitHub contributors](https://img.shields.io/github/contributors/InfiniTensor/digit-layout)
![GitHub commit activity](https://img.shields.io/github/commit-activity/m/InfiniTensor/digit-layout)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以参照rcrw那个库,再添加一个coverage的标签

@Shl1015CS Shl1015CS closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants