notifications: add option to clear all notifications #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaffeinatedKat
force-pushed
the
dismiss_all
branch
from
21ef157
to
dffc05f
Compare
|
Build checks have not completed. Possible reasons for this are:
|
|
@KaffeinatedKat What if you implemented a long press action that pops up your button in the middle of the screen? |
|
I thought about that, but I hate how inconsistent the long press action is detected, so I went with a swipe action because it's much more consistent |
|
If we ever get to implement iOS notifications, we will need both left and right swipe to interact with them. Not super relevant right now, but there might be a conflict in the (far) future. |
|
how come? How are iOS notifications different from android ones? |
|
Apple has its own BLE service 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an action to dismiss all notifications in the notification viewer. You swipe left and it moves the notification to reveal a button that dismisses all of the notifications. If the menu is open and you swipe right it closes.
The button looks kinda jank currently. I really like the idea of swiping to reveal a button, but I don't know how to make it look good