Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchface: add weather option to Casio style watchface #2099

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Ghoelian
Copy link

@Ghoelian Ghoelian commented Aug 4, 2024

Adds the option to turn one of the segments on the Casio watchface into weather.
InfiniSim_2024-08-04_230833
InfiniSim_2024-08-04_230835
InfiniSim_2024-08-04_230942

Copy link

github-actions bot commented Aug 4, 2024

Build size and comparison to main:

Section Size Difference
text 374596B 1588B
data 948B 0B
bss 22544B 8B

@rnwgnr
Copy link

rnwgnr commented Nov 21, 2024

Das PR does not apply anymore due to the recent changes in the weather subsystem - would be cool to have this updated against the current state of main.

@Ghoelian
Copy link
Author

Ah alright, I'll look into getting it updated when I get the time.

@Ghoelian
Copy link
Author

I've updated my branch, seems to be working on my watch.

@rnwgnr
Copy link

rnwgnr commented Nov 22, 2024

Updated my watch and it works like a charm as it did before. Thanks.

Would be nice to see this included in 1.16.

@tituscmd
Copy link
Contributor

Would it be possible to choose which segment is replaced by weather?
I made a hardcoded version of your idea as well a while back, but I replaced WeekNumber instead. If you could implement a way to choose which segment is replaced, we could essentially merge those ideas into one big PR.
image

@Ghoelian
Copy link
Author

Would it be possible to choose which segment is replaced by weather? I made a hardcoded version of your idea as well a while back, but I replaced WeekNumber instead. If you could implement a way to choose which segment is replaced, we could essentially merge those ideas into one big PR. image

Yeah I think I can do that, doesn't sound too difficult.

@tituscmd
Copy link
Contributor

For reference, I put the weather icon to align top left at 10, 22 and the temperature to align top left 45, 22
Feel free to just copy these or take them as a reference point for improving the looks of it.

@Ghoelian
Copy link
Author

InfiniSim_2024-11-25_203125
InfiniSim_2024-11-25_203132

Added these two options.

@tituscmd
Copy link
Contributor

Oh I might even like that more than my approach! Good job, will definitely be using this, at least once 1.15 rolls out 😁

@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Nov 28, 2024
@tituscmd
Copy link
Contributor

tituscmd commented Dec 9, 2024

For the segment that replaces the weeknumber, you should center the temperature and weather icon based on the weekday and offset them vertically (in the negative direction of course, since you're going up on the display).

Also, you merged something about notif vibration strength. I don't think you meant to put this into the PR.

Other than that, I'd love to have this in 1.16.0!

@Ghoelian
Copy link
Author

Ghoelian commented Dec 9, 2024

Oops sorry yeah didn't mean to commit the vibration stuff to this branch, I'll fix that when I get the time.

@rnwgnr
Copy link

rnwgnr commented Dec 23, 2024

Oops sorry yeah didn't mean to commit the vibration stuff to this branch, I'll fix that when I get the time.

I came across this "accidental addition" and i really like it. Would be cool if you'd provide an additional PR for this.

@Ghoelian
Copy link
Author

Sorry it took so long, but I've finally removed the unrelated commits. I'll get to fixing the alignment later!

@Ghoelian
Copy link
Author

The merge box thingy is telling me one of the reasons merging is blocked because the branch "must not contain merge commits". Is this a real requirement for getting this merged?

@Ghoelian
Copy link
Author

@rnwgnr created #2231 for the vibration settings

@tituscmd
Copy link
Contributor

Sorry it took so long, but I've finally removed the unrelated commits. I'll get to fixing the alignment later!

About the alignment, you can check my branch with the extremely long name of "1.15_ANCS_HR_CASIO_DGTL-W" where I think I nailed the alignment perfectly.

Here's a few pics:
image
image
image

@Ghoelian
Copy link
Author

I've been having some issues getting the simulator running on my setup (trying to run from a dev container), but I'll hopefully fix that and then this PR this weekend.

@Ghoelian
Copy link
Author

@tituscmd I've fixed the alignment, looks a lot better now!

@tituscmd
Copy link
Contributor

Awesome! Glad to have been of help here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants