-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watchface: add weather option to Casio style watchface #2099
base: main
Are you sure you want to change the base?
Conversation
Build size and comparison to main:
|
Das PR does not apply anymore due to the recent changes in the weather subsystem - would be cool to have this updated against the current state of |
Ah alright, I'll look into getting it updated when I get the time. |
I've updated my branch, seems to be working on my watch. |
Updated my watch and it works like a charm as it did before. Thanks. Would be nice to see this included in 1.16. |
For reference, I put the weather icon to align top left at 10, 22 and the temperature to align top left 45, 22 |
Oh I might even like that more than my approach! Good job, will definitely be using this, at least once 1.15 rolls out 😁 |
For the segment that replaces the weeknumber, you should center the temperature and weather icon based on the weekday and offset them vertically (in the negative direction of course, since you're going up on the display). Also, you merged something about notif vibration strength. I don't think you meant to put this into the PR. Other than that, I'd love to have this in 1.16.0! |
Oops sorry yeah didn't mean to commit the vibration stuff to this branch, I'll fix that when I get the time. |
I came across this "accidental addition" and i really like it. Would be cool if you'd provide an additional PR for this. |
5728a4b
to
2d180c8
Compare
Sorry it took so long, but I've finally removed the unrelated commits. I'll get to fixing the alignment later! |
The merge box thingy is telling me one of the reasons merging is blocked because the branch "must not contain merge commits". Is this a real requirement for getting this merged? |
I've been having some issues getting the simulator running on my setup (trying to run from a dev container), but I'll hopefully fix that and then this PR this weekend. |
@tituscmd I've fixed the alignment, looks a lot better now! |
Awesome! Glad to have been of help here 😄 |
Adds the option to turn one of the segments on the Casio watchface into weather.