Fix lint issue, add backend permission check for SAML SSO enforcement…

… toggle
Infisical · Feb 9, 2024 · 069b0cd · 069b0cd
1 parent ed23bd4
commit 069b0cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/backend/src/services/org/org-service.ts b/backend/src/services/org/org-service.ts
@@ -131,6 +131,10 @@ export const orgServiceFactory = ({
     const { permission } = await permissionService.getOrgPermission(actor, actorId, orgId, actorOrgId);
     ForbiddenError.from(permission).throwUnlessCan(OrgPermissionActions.Edit, OrgPermissionSubjects.Settings);
 
+    if (authEnforced !== undefined) {
+      ForbiddenError.from(permission).throwUnlessCan(OrgPermissionActions.Edit, OrgPermissionSubjects.Sso);
+    }
+
     if (authEnforced) {
       const samlCfg = await samlConfigDAL.findEnforceableSamlCfg(orgId);
       if (!samlCfg)

diff --git a/frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/OrgGeneralAuthSection.tsx b/frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/OrgGeneralAuthSection.tsx
@@ -34,7 +34,6 @@ export const OrgGeneralAuthSection = () => {
                 await logout.mutateAsync();
                 window.open(`/api/v1/sso/redirect/saml2/organizations/${currentOrg.slug}`);
                 window.close();
-                return;
             }
 
         } catch (err) {