Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIM Provisioning #1424

Merged
merged 11 commits into from
Feb 22, 2024
Merged

SCIM Provisioning #1424

merged 11 commits into from
Feb 22, 2024

Conversation

dangtony98
Copy link
Collaborator

@dangtony98 dangtony98 commented Feb 19, 2024

Description 📣

This PR adds preliminary support for SCIM provisioning with documentation for Okta, Azure, and JumpCloud SCIM clients.

Suppose the SCIM server is Infisical, providers like Okta are SCIM clients, and "The User" is an administrator. The expected flow is as follows:

  1. The User in Infisical creates a SCIM token for the SCIM client to use under traditional Authentication Bearer header.
  2. The User configures the SCIM client with the SCIM token from Step 1, their SCIM URL, and any other client-specific configuration. This allows the SCIM client to authenticate and forward updates to the SCIM server.
  3. The SCIM client can now provision/deprovision users to/from the SCIM server.

More specifically, it includes:

  • Frontend for SCIM token generation.
  • Backend endpoints + schema for SCIM token management, scimEnabled field addition onto organization.
  • Backend /Users endpoints for SCIM client to interface with Infisical.
Screenshot 2024-02-19 at 2 39 48 PM

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Copy link

gitguardian bot commented Feb 19, 2024

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9387833 Triggered Generic Password e15ed4c docker-compose.pg.yml View secret
9387833 Triggered Generic Password e15ed4c docker-compose.dev.yml View secret
9387833 Triggered Generic Password e15ed4c .env.example View secret
9387833 Triggered Generic Password e15ed4c docker-compose.pg.yml View secret
9387833 Triggered Generic Password e15ed4c docker-compose.dev.yml View secret
8529478 Triggered Generic High Entropy Secret e15ed4c .env.example View secret
9605379 Triggered Generic High Entropy Secret 318ad25 backend/src/db/seed-data.ts View secret
9605380 Triggered Generic Private Key 318ad25 backend/e2e-test/routes/v3/secrets.spec.ts View secret
9605380 Triggered Generic Private Key 318ad25 backend/e2e-test/routes/v3/secrets.spec.ts View secret
9605381 Triggered Generic High Entropy Secret 318ad25 .env.test.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

maidul98
maidul98 previously approved these changes Feb 21, 2024
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure the migration you created 20240208234120 falls as the last one. To make sure, you can just create a new migration and update this time stamp with it before merging. Otherwise i skimmed through and didn't see anything major

@dangtony98 dangtony98 merged commit 2eb9592 into main Feb 22, 2024
5 of 6 checks passed
@dangtony98 dangtony98 deleted the scim branch February 22, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants