Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(telemetry): added back email for telemetry when using service token #1443

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix(telemetry): added back email for telemetry when using service token #1443

merged 2 commits into from
Feb 22, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

  1. Email is added back on telemetry posthog event when using service token
  2. Fixed eslint warning from scim feature development

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh added the 🧨 backend This would need backend changes. label Feb 22, 2024
@akhilmhdh akhilmhdh self-assigned this Feb 22, 2024
maidul98
maidul98 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app

@maidul98 maidul98 merged commit f4386c2 into Infisical:main Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

@dangtony98 dangtony98 Awaiting requested review from dangtony98

@DanielHougaard DanielHougaard Awaiting requested review from DanielHougaard

Assignees

@akhilmhdh akhilmhdh

Labels
🧨 backend This would need backend changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akhilmhdh @maidul98