(Feat): V2 slugified project routes #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
force-pushed
the
daniel/slug-projects
branch
from
a9b8691
to
85c3a69
Compare
5 tasks
|
NOTE: The breaking change check will fail, because we've changed the create project router to take an organization slug instead of an organization ID. This is a public API endpoint documented on our API reference page. I've spoken to @maidul98 about this back when the change was made, and we decided to move forward with changing the endpoint. |
maidul98
reviewed
Mar 6, 2024
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
DanielHougaard
force-pushed
the
daniel/slug-projects
branch
3 times, most recently
from
0aa0bb4
to
29cc94f
Compare
5 tasks
maidul98
reviewed
Mar 15, 2024
maidul98
previously approved these changes
Mar 15, 2024
DanielHougaard
force-pushed
the
daniel/slug-projects
branch
from
2d51802
to
14ce7a2
Compare
maidul98
previously approved these changes
Mar 17, 2024
author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345579 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345572 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345563 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345551 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345540 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345533 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345529 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345522 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345503 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345496 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345489 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345357 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345061 +0100 parent 10a292b author Daniel Hougaard <[email protected]> 1709970985 +0100 committer Daniel Hougaard <[email protected]> 1710345029 +0100 Feat: Org Scoped JWT Tokens Add link button Fix: Avoid invalidating all queries on logout to prevent UI glitch Update _app.tsx Feat: Scoped JWT to organization, add authMethod to request Feat: Scoped JWT to organization, Add authMethod to services Feat: Scoped JWT to organization, require organization on all requests by default on JWT requests Update index.ts Feat: Scoped JWT to organization Chore: Move SAML org check to permission service Feat: Scoped JWT to organization, actorAuthMethod to create project DTO Fix: Invalidate after selecting organization Chore: Optional 'invalidate' option for create org hook Fix: Creating dummy workspaces Fix: Select org after creation Feat: Org Scoped JWT's, remove inline service Fix: ActorType unresolved Fix: Better type checking Feat: Org scoped JWT's Fix: Add missing actor org ID Fix: Add missing actor org ID Fix: Return access token Update auth-type.ts Fix: Add actor org ID Chore: Remove unused code Fix: Add missing actor org ID to permission check Fix: Add missing actor auth method to permission checks Fix: Include actor org id Chore: Remove redundant lint comment Fix: Add missing actorOrgId to service handlers Fix: Rebase fixes Fix: Rebase LDAP fixes Chore: Export Cli login interface Update queries.tsx Feat: Org scoped JWT's CLI support Update inject-permission.ts Fix: MFA Remove log Fix: Admin signup, select organization Improvement: Use select organization hook Update permission-service.ts Fix: Make API keys compatible with old endpoints Update inject-permission.ts Chore: Better error messages Update index.ts Fix: Signup not redirecting to backup PDF page due to error Select org on signup Type improvements Chore: Removed code that spans out of scope Fix: Better types Chore: Move comment Chore: Change order Fix: Code readability Fix: Code readability Update auth-token-service.ts Chore: Remove old comments Fix: Cleanup Chore: Minor code cleanup Fix: Add auth method and organization ID to test JWT Fix: Get org ID in getOrgIdentityPermission DAL operation
DanielHougaard
force-pushed
the
daniel/slug-projects
branch
from
bc092cc
to
1ac8ddb
Compare
maidul98
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR introduces new routes on the V2 api
(/api/v2/workspace), that use project slugs instead of project ID's. This is a prerequisite for adding project support to our Terraform provider.I've introduced a new project DAL operation called
getProjectByFilter, which will make it easier to query for projects based on both slugs and ID's.Additionally, this PR also fixes the v1 update project endpoint. The endpoint is currently only accessible with the JWT auth method. It's now also accessible by MI's.
Type ✨