-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry stats event for self hosted instance on midnight #1471
Telemetry stats event for self hosted instance on midnight #1471
Conversation
…to avoid db calls
…est first boot up and fixed making values optional on create rows for generate schema
…e stats to posthog on midnight
In the future, please try to separate into separate PRs. The shorter the PR, the quicker it is to review |
@maidul98 yah but this one was depending on the other change. All the changes are related to this PR. Except the schema file auto generated changes the PR is small |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few typos, I use https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker and it works great, you should use it too.
I also saw that you removed created/updated at fields from config api and it looks like these fields are not used by the frontend so it should be fine to be breaking.
Made some other minor edits but otherwise looks good!
const startTelemetryCheck = async () => { | ||
// this is a fast way to check its cloud or not | ||
if (appCfg.LICENSE_SERVER_KEY) return; | ||
// clear previous job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LICENSE_SERVER_KEY
is only supplied for enterprise self host. I had switched it to INFISICAL_CLOUD
Description 📣
On fresh bootup in replication there could be two server cfg rows created, rare but possible. Thus we keep server cfg with an id of
00000
and then fetch that one always.zod.infer
->zod.input
for insert and update. That's the schema changes mostType ✨
Tests 🛠️
# Here's some code block to paste some code snippets