-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LDAP authentication + Aliases #1475
Conversation
const doc = await orgBotDAL.findOne({ orgId }, tx); | ||
if (doc) return doc; | ||
|
||
const { privateKey, publicKey } = generateAsymmetricKeyPair(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the encryption to outside the transaction. Because the more time a transaction takes the more table lock in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this at first but I think the encryption logic is actually not expensive; I've taken this from somewhere else in the codebase where this pattern was implemented.
frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/LDAPModal.tsx
Show resolved
Hide resolved
frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/LDAPModal.tsx
Outdated
Show resolved
Hide resolved
…er compose profile, update ldap form logic to use zod
Description 📣
This PR adds support for the LDAP authentication method.
With this update, an admin can configure an organization in Infisical to connect to an LDAP server (e.g. Active Directory, JumpCloud LDAP, etc.). After doing so, users that log in via the LDAP method are created to exist within the corresponding organization in Infisical only and hence can only access that organization.
This includes:
username
field for users hereon instead ofemail
.Type ✨