Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): disable sso authentication method #1481

Closed
wants to merge 1 commit into from

Conversation

Salman2301
Copy link
Contributor

Description 📣

This add ability for super admin to disable any SSO / email authentication methods available in Infisical across organizations. Even though this methods only work, if the authentication ENV is setup properly. I was thinking we can hide the button in the frontend for the user and also add some checks to protect login/register route. So, for a large organization this can be handy.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Admin Dashboard _ Infisical · 1 13am · 02-28

Test

  1. Checkout PR
  2. goto Admin panel
  3. disable email
  4. logout the current user
  5. login the user via email. Should throw an error

@maidul98
Copy link
Collaborator

I think what would make more sense is to just hide all of the SSO that has not been configured on the sign up page. This is because when a SSO is configured (environment varables are set for it), we can assume it is meant to be used.

What do you think?

@Salman2301
Copy link
Contributor Author

@maidul98 agree with you on it.
This makes thing simple.

In addition hiding unconfigured SSO, we need a way to disable Local authentication method. May be will add that instead of the current UI to hide all authentication method.

I will send you my reason via private slack.

@Salman2301 Salman2301 closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants