Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret input auto complete #1572

Merged
merged 38 commits into from
Apr 25, 2024

Conversation

Salman2301
Copy link
Contributor

@Salman2301 Salman2301 commented Mar 14, 2024

Description 📣

Improve secret input component auto complete, lint and error validations

  • Move to react query
  • Use Radix component for portal, scroll and keyboard navigation popup
  • Refactor onChange?
  • Fix popup position on overview (Maybe move to radix component will fix it)
  • Invalidate Input on improper reference
  • Escape [dot] character
  • Highlight different color for env, folders and secrets? (Different color can be too heavy skipping for now)
  • invalidate / . in environment slug

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

output_video.mp4
# Here's some code block to paste some code snippets

@Salman2301 Salman2301 marked this pull request as ready for review March 16, 2024 01:15
@Salman2301
Copy link
Contributor Author

This is ready for review

@Grraahaam
Copy link
Contributor

The result looks great! This will be really useful! Well done 👏🏽

@Salman2301
Copy link
Contributor Author

The UI in the video is kind of outdated after moved to Radix component.
Will update it later

@Salman2301
Copy link
Contributor Author

Using Radix component... looks better in secret overview cause of portal I believe but input get out of focus on this version everytime it's popup
https://github.com/Infisical/infisical/assets/40920317/ea0e6303-92f8-43c4-bcc4-571657b9c2f6

@maidul98
Copy link
Collaborator

@Salman2301 wow this looks great! @akhilmhdh can you please help @Salman2301 get this into main?

Copy link
Member

@akhilmhdh akhilmhdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know after the changes has been made. Ill test more of the edge cases and ill try to simplify the whole code

@vmatsiiako
Copy link
Collaborator

Hey guys! Really excited about this PR! When are you thinking to merge this?

@Grraahaam
Copy link
Contributor

Hey @Salman2301, are you still working on this? It sure looks really useful!

@sheensantoscapadngan
Copy link
Member

Hey @Salman2301! I'd like to work on top of this and help you finally resolve this PR. I'll be pushing a few changes in a bit.

Copy link

gitguardian bot commented Apr 23, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password fb69236 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sheensantoscapadngan
Copy link
Member

2024-04-24.01-45-00.mp4

Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@maidul98 maidul98 merged commit 49c735c into Infisical:main Apr 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants