-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret input auto complete #1572
Secret input auto complete #1572
Conversation
This is ready for review |
The result looks great! This will be really useful! Well done 👏🏽 |
The UI in the video is kind of outdated after moved to Radix component. |
Using Radix component... looks better in secret overview cause of portal I believe but input get out of focus on this version everytime it's popup |
@Salman2301 wow this looks great! @akhilmhdh can you please help @Salman2301 get this into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know after the changes has been made. Ill test more of the edge cases and ill try to simplify the whole code
frontend/src/views/SecretRotationPage/components/CreateRotationForm/steps/RotationInputForm.tsx
Outdated
Show resolved
Hide resolved
...src/views/Settings/ProjectSettingsPage/components/EnvironmentSection/AddEnvironmentModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/v2/SecretInput/SecretReferenceSelect.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/v2/SecretInput/SecretReferenceSelect.tsx
Outdated
Show resolved
Hide resolved
Hey guys! Really excited about this PR! When are you thinking to merge this? |
Hey @Salman2301, are you still working on this? It sure looks really useful! |
Hey @Salman2301! I'd like to work on top of this and help you finally resolve this PR. I'll be pushing a few changes in a bit. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Password | fb69236 | .env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
.../views/Settings/ProjectSettingsPage/components/EnvironmentSection/UpdateEnvironmentModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/v2/InfisicalSecretInput/InfisicalSecretInput.tsx
Outdated
Show resolved
Hide resolved
2024-04-24.01-45-00.mp4 |
frontend/src/components/v2/InfisicalSecretInput/InfisicalSecretInput.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Description 📣
Improve secret input component auto complete, lint and error validations
onChange
?Highlight different color for env, folders and secrets?(Different color can be too heavy skipping for now)/
.
in environment slugType ✨
Tests 🛠️
output_video.mp4
# Here's some code block to paste some code snippets