-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Machine Identity support for CLI commands #1630
Conversation
6737664
to
b423696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits. Did some testing and found some bugs. Let's make sure to test all the existing commands to make sure they work just like they used to
Two issues i see is different behavior of login when its user and universal auth. I tried user, where it asked my hosted infisical url where as universal auth,i tried with production infisical so i was stuck for some time to identity the issue as it didn't ask for self hosted. Next issue is how much it became harder to get started. The beauty of service token was its quite straight forward. Get the token, apply it and done. Now the issue is first i need to generate it and then i can't directly pipe it out too because of intermediate information like titles etc. Then need to manually copy it too. I feel like this will cause quite traction in usage |
Added flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description 📣
Type ✨