Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user identities & machine identities to stripe billing #1916

Conversation

ShubhamPalriwala
Copy link
Contributor

Description 📣

  • Adds versioning in Organization schema as billingVersion where
    • v0 is the current developer based pricing where only users are charged
    • v1 is the new pricing where identities (users & machines) are charged
  • Combined limit of 5 for both users as well as machine identities
  • Updates & Validates identity limit check on creation & deletion of users as well as machine identities

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

Run with the license server locally and test the new limits + combined pricing

# Here's some code block to paste some code snippets

@dangtony98 dangtony98 closed this Jun 18, 2024
@dangtony98
Copy link
Collaborator

dangtony98 commented Jun 18, 2024

Closed because the desired implementation should be such that the Infisical application itself is unaware of any pricing scheme / versioning-related information; it should simply pull back the feature set from the license server including any identity-related restricitons.

This logic should be fully centralized on the side of Stripe / license server so that, for example, if we needed to know who is on the so-called billing version v2 then we can obtain that information in Stripe instead of querying the DB here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants