-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Default organization slug for LDAP/SAML #2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you are doing. User enters slug, and you take the slug and get it's id and save the id and when we get the admin config, we returns the id and the associated slug.
I just remembered, one of the friction points i observed watching customer do this is not knowing where the org slug is located at since it is their first time setting things up. I think it will be a better experience if they can just select a org from a drop down (we already have a API for getting users orgs) and then we send the id to the DB and save as is. When we fetch admin config, we can compute org slug as you do now. This way, saving is identical to before too
Looks good to me.
Dismissing since handing it over to @maidul98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, tried to load things up with a fresh DB and the migration that creates the instance row in the DB doesn't get created so the APIs throw error when it calls get config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's definitely test in gamma since this not working will impact logins for enterprises
…default slug is provided
… "defaultAuthOrgSlug"
3c81570
to
5a95751
Compare
Description 📣
Main
We now have a way of setting the default slug as a part of the admin settings / server configuration. When the default org slug is set, a few things will happen:
Technical:
Instead of storing the organization slug as text in the database, we're storing a reference to the organization itself by ID. This will allow cascading to work, and I generally believe we should always be keeping references instead of just plain text when we're keeping track of resources.
Minor:
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets