Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowed toggling login options as admin #2026

Merged
merged 14 commits into from
Jul 2, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Jun 26, 2024

Description 📣

  • This PR will allow admins to adjust the allowed login methods from the Admin configuration page
  • Filters options in the Personal Settings Page, Organization settings > Security panel, login page, and signup page
  • Adds "is enabled" checks to login routes for all methods
image image

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@sheensantoscapadngan sheensantoscapadngan marked this pull request as draft June 26, 2024 15:23
@sheensantoscapadngan sheensantoscapadngan marked this pull request as ready for review June 27, 2024 04:52
@maidul98
Copy link
Collaborator

I'm still seeing SCIM when the only thing i have on is email
CleanShot 2024-06-27 at 20 32 15@2x

Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, i also played aroud with it and it works well! Just left a small comment

@maidul98
Copy link
Collaborator

CleanShot 2024-06-27 at 20 45 41@2x

I'm seeing a blank page when i click the sign up but i'm thinking it shouldn't show at all unless email auth or one of the auth SSO are enabled. What do you think?

Also we'll have to think about for password reset link

@sheensantoscapadngan
Copy link
Member Author

Sign up text is now hidden when none of the ff is enabled: email, github, gitlab, google
image

Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maidul98 maidul98 merged commit 935a3cb into main Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants