AWS Secret Manager assume role based integration #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
requested review from
sheensantoscapadngan
and removed request for
maidul98
backend/src/db/migrations/20240626111536_integration-auth-aws-assume-role.ts
Show resolved
Hide resolved
backend/src/services/integration-auth/integration-sync-secret.ts
Outdated
Show resolved
Hide resolved
…o pick it automatically
… assume and access key
sheensantoscapadngan
approved these changes
Jun 27, 2024
|
@maidul98 merge this only when you have enough time to update and check things in staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
PR introduces aws secret manager integration to use assume role feature to avoid sharing client's access key and secret key.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets