feat: added native slack webhook type #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TO DO: add documentation |
|
Added the folllowing to do the docs: |
akhilmhdh
requested changes
Jul 3, 2024
backend/src/db/migrations/20240702055253_add-encrypted-webhook-url.ts
Outdated
Show resolved
Hide resolved
|
Also one more reminder. Try a fake slack so that it fails and check the log if the url is getting printed. If so redact it for security reasons |
Can we also make the environment in new line |
checked this one as well @akhilmhdh. We're not logging the URL in the case of errors. In fact, we don't log anything if a webhook request fails |
akhilmhdh
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets