Secret approval with groups #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maidul98 After review, merge when your also available as this is migration change |
|
@sheensantoscapadngan ping me in slack when you are done with the review and i'll skim over it before deploy |
backend/src/ee/services/secret-approval-policy/secret-approval-policy-service.ts
Show resolved
Hide resolved
backend/src/ee/services/secret-approval-policy/secret-approval-policy-service.ts
Show resolved
Hide resolved
|
group members not shown in policy user selection resolved: another effort |
sheensantoscapadngan
approved these changes
Jul 4, 2024
maidul98
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR enables secret approval to work with users part of groups. Instead of project membership we now take user id in secret approval. The api now returns the corresponding user details for various user entities like statusChangeBy, committer etc
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets