Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag based filtering for secret endpoint #2242

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

This PR brings back tag based filtering for secret raw endpoints for both v2 and v3 projects. The respective changes are made in CLI to do the same

Closes #2229

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh added 🧨 backend This would need backend changes. 🪓 cli labels Aug 6, 2024
@akhilmhdh akhilmhdh requested a review from maidul98 August 6, 2024 10:10
@akhilmhdh akhilmhdh self-assigned this Aug 6, 2024
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left 2 comments. let's just double check we aren't missing the name field because that will break peoples terraform state

@akhilmhdh akhilmhdh merged commit ea14df2 into Infisical:main Aug 9, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨 backend This would need backend changes. 🪓 cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tags filter support for secrets v3 API
2 participants