misc: addressed reported flaws with CLI usage #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheensantoscapadngan
changed the title
sheensantoscapadngan
changed the title
maidul98
reviewed
Aug 8, 2024
akhilmhdh
requested changes
Aug 9, 2024
There was a problem hiding this comment.
CLI operations seems to be working fine on my end now.
Only one catch is secrets set when doing it against without a workspace config file and without token doesn't throw any error. It just returns an empty table kinda weird because i didn't understand what happened
sheensantoscapadngan
force-pushed
the
misc/addressed-reported-cli-behaviors
branch
from
fd83c36
to
14c1b4f
Compare
akhilmhdh
previously approved these changes
Aug 10, 2024
sheensantoscapadngan
force-pushed
the
misc/addressed-reported-cli-behaviors
branch
from
985121b
to
14c1b4f
Compare
akhilmhdh
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR addresses two issues in the CLI:
secrets setcommand requiring local workspace config file even when using auth tokenssecrets geteven with the--plainflagThe PR also adds an API for fetching project ID by slug or name which will make CLI usage easier to automate
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets