Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved keyring dataset too big by keeping only the encryption key #2254

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

akhilmhdh
Copy link
Member

@akhilmhdh akhilmhdh commented Aug 8, 2024

Description 📣

This PR fixes a major issue in CLI that got popped up due to recent release. Some of the users who started using it suddenly ended up having the new fallback vault when doing normal commands like run etc. This caused a big hit on user experience. The fallback should not have triggered because else login would not have happened.

The root issue was the switch from backup secret for offline access towards the keyring. According to docs keyring cannot sustain more than 3kb in mac. Thus total payload going more than that would fail. This is why we couldn't reproduce this on our end initially. To resolve this we moved back to old way but the encryption key is saved in keyring now.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh added the 🐞 bug Something isn't working label Aug 8, 2024
@akhilmhdh akhilmhdh requested a review from maidul98 August 8, 2024 07:42
@akhilmhdh akhilmhdh self-assigned this Aug 8, 2024
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed vault use command, and auto generated password because it would never be used by the user anyways. Both infisical vault set file and keyringset command use auto generted passphrase

@maidul98 maidul98 merged commit f7d882a into Infisical:main Aug 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants