Resolved keyring dataset too big by keeping only the encryption key #2254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR fixes a major issue in CLI that got popped up due to recent release. Some of the users who started using it suddenly ended up having the new fallback vault when doing normal commands like
run
etc. This caused a big hit on user experience. The fallback should not have triggered because else login would not have happened.The root issue was the switch from backup secret for offline access towards the keyring. According to docs keyring cannot sustain more than 3kb in mac. Thus total payload going more than that would fail. This is why we couldn't reproduce this on our end initially. To resolve this we moved back to old way but the encryption key is saved in keyring now.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets