Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated ecs-with-agent documentation to use AWS native auth #2330

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Aug 23, 2024

Description 📣

  • This PR updates our documentation here to use AWS native auth instead of the universal auth
  • This also includes updating the agent configuration example file to use raw template directly inline

This PR is dependent on Infisical/infisical-guides#1

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@maidul98
Copy link
Collaborator

Is this not the same? https://github.com/Infisical/infisical/pull/2329/files

@sheensantoscapadngan
Copy link
Member Author

Is this not the same? https://github.com/Infisical/infisical/pull/2329/files

Yeah it builds on top of that PR. We can merge that in first and then this one

@sheensantoscapadngan sheensantoscapadngan dismissed maidul98’s stale review August 29, 2024 18:25

The merge-base changed after approval.

maidul98
maidul98 previously approved these changes Aug 29, 2024
@maidul98 maidul98 merged commit b975996 into main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants