Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Persistent self-hosting domains on infisical login #2331

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

DanielHougaard
Copy link
Contributor

Description 📣

This PR implements persistent self-hosting domains for infisical login. Additionally, it also incldues a new flag on the login command, called clear-domains. In some cases users may want to wipe their saved domains, and this flag does exactly yhat.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Copy link
Member

@akhilmhdh akhilmhdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small case missing. That is filtering of same domains. I can enter the same domain twice and the list will have two same domains.

@DanielHougaard DanielHougaard requested review from akhilmhdh and removed request for maidul98 August 26, 2024 11:09
@DanielHougaard DanielHougaard merged commit 436ccb2 into main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants