Root encrypted data to kms encryption#2827
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
maidul98
left a comment
There was a problem hiding this comment.
Left some small comments. For manual testing i tried with:
- ladap config [good]
- dynamic secret with pg [seems to save and all but says the password is wrong?]
- secret rotation [seems to save and all but says the password is wrong?]
- webhooks [good]
Also what about integrations and are there any other items we are missing on this pass? What about the server admin slack secrets?

eb705eb to
9554630
Compare
9554630 to
b2ce14e
Compare
bfb10bf to
a24faf1
Compare
da01275 to
8028b6b
Compare
maidul98
left a comment
There was a problem hiding this comment.
The old way of running the migrations should still work. If no migrations are needed, then it should just skip. If it needs some environment varables, then we should throw the error telling them.
You can try this behavior by uisng our old .dev.yaml docker compose file.
Also got this at some point when i tried to boot up:
|
admins should be able to migrate down without defining the new envs |
… to some kinda conflicts
490ce5c to
6b3b13e
Compare

Description 📣
This PR adds migration to remove all directly root encrypted schemas with our new kms architecture. This also allows migrations to use kms features.
All the unused fields are kept nullable and not dropped. Will be doing a rolling migration for this to remove it later.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets