Improvement(helm chart): Allow use of redis existingSecret #4428
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This addresses #4421
In summary, this PR removes REDIS_URL from the infisical deployment if .Values.redis.auth.existingSecret is populated.
The redis subchart will use auth.existingSecret and auth.existingSecretPasswordKey already without issue. The problem then becomes specifying the correct REDIS_URL string which includes the password. This now allows the user to specify their own REDIS_URL (via secret) by removing the REDIS_URL when redis.auth.existingSecret is set.
Type ✨
Tests 🛠️
helm template --debug returns no issues. I have also packaged the chart using helm package and used it directly and it works exactly as it should.