Skip to content

[WIP] feat(dashboard): Only fetch secret value on relevant actions #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 19, 2025
Merged

[WIP] feat(dashboard): Only fetch secret value on relevant actions #4545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8f8e8d3
wip
scott-ray-wilson Sep 17, 2025
5a4b83d
improvements: address feedback progress
scott-ray-wilson Sep 18, 2025
a95f491
improvements: address feedback 2
scott-ray-wilson Sep 18, 2025
f1f391f
improvements: fix commit changes with value retrieval
scott-ray-wilson Sep 18, 2025
120b767
improvement: remove comments
scott-ray-wilson Sep 18, 2025
999ce3f
improvements: resolve more commit state issues form value reveal change
scott-ray-wilson Sep 18, 2025
91d3ed6
improvement: reduce code duplication for copy value
scott-ray-wilson Sep 18, 2025
55b240f
improvement: skip edit/delete permissions for personal secrets
scott-ray-wilson Sep 18, 2025
c6c3f2c
improvements: address more feedback
scott-ray-wilson Sep 18, 2025
1a995b6
merge main
scott-ray-wilson Sep 18, 2025
3701858
improvements: final feedback
scott-ray-wilson Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion backend/src/ee/services/audit-log/audit-log-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,11 @@ export enum EventType {

CREATE_SECRET_REMINDER = "create-secret-reminder",
GET_SECRET_REMINDER = "get-secret-reminder",
DELETE_SECRET_REMINDER = "delete-secret-reminder"
DELETE_SECRET_REMINDER = "delete-secret-reminder",

DASHBOARD_LIST_SECRETS = "dashboard-list-secrets",
DASHBOARD_GET_SECRET_VALUE = "dashboard-get-secret-value",
DASHBOARD_GET_SECRET_VERSION_VALUE = "dashboard-get-secret-version-value"
}

export const filterableSecretEvents: EventType[] = [
Expand Down Expand Up @@ -3510,6 +3514,34 @@ interface ProjectDeleteEvent {
};
}

interface DashboardListSecretsEvent {
type: EventType.DASHBOARD_LIST_SECRETS;
metadata: {
environment: string;
secretPath: string;
numberOfSecrets: number;
secretIds: string[];
};
}

interface DashboardGetSecretValueEvent {
type: EventType.DASHBOARD_GET_SECRET_VALUE;
metadata: {
secretId: string;
secretKey: string;
environment: string;
secretPath: string;
};
}

interface DashboardGetSecretVersionValueEvent {
type: EventType.DASHBOARD_GET_SECRET_VERSION_VALUE;
metadata: {
secretId: string;
version: string;
};
}

interface ProjectRoleCreateEvent {
type: EventType.CREATE_PROJECT_ROLE;
metadata: {
Expand Down Expand Up @@ -3889,6 +3921,9 @@ export type Event =
| SecretReminderCreateEvent
| SecretReminderGetEvent
| SecretReminderDeleteEvent
| DashboardListSecretsEvent
| DashboardGetSecretValueEvent
| DashboardGetSecretVersionValueEvent
| ProjectRoleCreateEvent
| ProjectRoleUpdateEvent
| ProjectRoleDeleteEvent
Expand Down
Loading
Loading