Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag support for secret resource #37

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

akhilmhdh
Copy link
Member

@akhilmhdh akhilmhdh commented Jun 14, 2024

Add support for tags feature in secrets resource.

Before merging this PR ensure this PR is merged and deployed

@akhilmhdh akhilmhdh added the enhancement New feature or request label Jun 14, 2024
@akhilmhdh akhilmhdh requested a review from maidul98 June 14, 2024 13:12
@akhilmhdh akhilmhdh self-assigned this Jun 14, 2024
Copy link
Contributor

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me/ Just some nits. How thoroughly did you test it? Do i need to do some on my end?

@maidul98 maidul98 merged commit 71d418f into Infisical:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants