INJICERT-661 review comments

Signed-off-by: Hitesh Jain <[email protected]>
Infosys · Feb 6, 2025 · 96915cb · 96915cb
1 parent 348286b
commit 96915cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/docker-compose/docker-compose-injistack/docker-compose.yaml b/docker-compose/docker-compose-injistack/docker-compose.yaml
@@ -31,8 +31,8 @@ services:
       - ./config/certify-csvdp-farmer.properties:/home/mosip/config/certify-csvdp-farmer.properties
       - ./config/certify-mock-mdl.properties:/home/mosip/config/certify-mock-mdl.properties
       - ./data/CERTIFY_PKCS12:/home/mosip/CERTIFY_PKCS12
-      # This can be enabled if one uses inji-certify docker image instead of inji-certify-with-plugins
-      #- ./loader_path/certify/:/home/mosip/additional_jars/
+      # This can be disabled if one uses plugins included in inji-certify-with-plugins docker image.
+      - ./loader_path/certify/:/home/mosip/additional_jars/
       # modify the below file to change the identity fields in the VC
       - ./config/farmer_identity_data.csv:/home/mosip/config/farmer_identity_data.csv
     networks:

diff --git a/docs/README.md b/docs/README.md
@@ -15,4 +15,7 @@ any new plugin to be added can be added by volume mount to loader_path
 
 is_glowroot_env - this field is removed from configure_start.sh to remove dependency on glowroot apm
 
+
+
 ```
+moved client.zip to build time dependency in dockerfile - addition of new hsm-client zip can be done by adding it to volume mount in docker-compose or helm charts with same structure as [client.zip](https://raw.githubusercontent.com/mosip/artifactory-ref-impl/v1.3.0-beta.1/artifacts/src/hsm/client.zip)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,4 +15,7 @@ any new plugin to be added can be added by volume mount to loader_path

		is_glowroot_env - this field is removed from configure_start.sh to remove dependency on glowroot apm



		```
		moved client.zip to build time dependency in dockerfile - addition of new hsm-client zip can be done by adding it to volume mount in docker-compose or helm charts with same structure as [client.zip](https://raw.githubusercontent.com/mosip/artifactory-ref-impl/v1.3.0-beta.1/artifacts/src/hsm/client.zip)