Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply retry when the response is a "too many requests" #6

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

Initially this client didn't apply the retry mechanism for any client error since the client should change the request. However the 429 too many requests client error is a safe to retry after a grace period.

Solution

Apply the retry for 429 response errors

@Baptouuuu Baptouuuu added the enhancement New feature or request label Jul 17, 2024
@Baptouuuu Baptouuuu self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (14d4b83) to head (43a4cfb).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop       #6      +/-   ##
=============================================
+ Coverage      90.09%   90.61%   +0.51%     
- Complexity       120      121       +1     
=============================================
  Files             19       18       -1     
  Lines            737      735       -2     
=============================================
+ Hits             664      666       +2     
+ Misses            73       69       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit 3d67ae6 into develop Jul 17, 2024
23 checks passed
@Baptouuuu Baptouuuu deleted the retry-too-many-requests branch July 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant