Next major version #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR is here to add/modify this package in order for the next major version of
innmind/amqpto only rely on this abstraction and no longer access the underlyinginnmind/streamsorinnmind/io.This will allow
innmind/amqpto be used safely in an asynchronous context insideinnmind/mantle.What
Filesystem::temporary()to allow reading messages that may not fit in memory.innmind/ioto allow for a more declarative useinnmind/file-watch:~4.0Note
The update of
innmind/file-watchis not directly linked to the update ofinnmind/amqp. This update is here for consistency across the Innmind ecosystem by using the continuation pattern everywhere possible. And since it's a BC break it's the right occasion to add this in a new major release.