Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/storybook #11

Closed
wants to merge 19 commits into from
Closed

Feature/storybook #11

wants to merge 19 commits into from

Conversation

Legitgoons
Copy link
Collaborator

@Legitgoons Legitgoons commented May 27, 2024 •
edited
Loading

Description

  • Set up Storybook and automated deployment
  • Updated .npmignore & .gitignore

Changes

  • Installed Storybook.
  • Implemented publish.yml using GitHub Actions for automated Storybook deployment.
    • Additional configuration is required because the implementation is set to deploy to GitHub Pages. For more details, please refer to this guide.

@Legitgoons Legitgoons requested a review from BangDori May 27, 2024 14:47
@Legitgoons Legitgoons self-assigned this May 27, 2024
BangDori
BangDori reviewed May 27, 2024
View reviewed changes
Copy link
Member

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 버전만 추가해주시고, storybook 기본 이미지 파일들은 모두 제거해주셔도 될 것 같습니다~

BangDori
BangDori approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당~ workflow 실행하셔서 테스트 이후에 병합 진행해주세요!

@Legitgoons Legitgoons closed this May 29, 2024
@Legitgoons Legitgoons reopened this May 29, 2024
@Legitgoons Legitgoons closed this May 29, 2024
@Legitgoons
Copy link
Collaborator Author

package의 사이즈를 고려해 storybook용 repo를 따로 만들겠습니다!

@BangDori BangDori deleted the feature/storybook branch May 29, 2024 05:55
@BangDori BangDori restored the feature/storybook branch May 29, 2024 05:55
@Legitgoons Legitgoons deleted the feature/storybook branch June 9, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BangDori BangDori BangDori approved these changes

Assignees

@Legitgoons Legitgoons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legitgoons @BangDori