Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable prettier import order and reformat files #1041

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Oct 18, 2023

Description of the change

The @trivago/prettier-plugin-sort-imports Prettier plugin was there in the package.json file for some time but it wasn't working because we needed to add the plugin to the .prettierrc.js's plugins property.

I've added it and re-formatted the files to re-order the imports according to this plugin.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13179

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Oct 18, 2023
@a7medev a7medev changed the base branch from master to dev October 18, 2023 13:05
@InstabugCI
Copy link
Collaborator

Warnings
⚠️

You have not included a CHANGELOG entry!
You can find it at CHANGELOG.md.

Coverage Report

Label Coverage Status
JavaScript 95.8%
Android 50.3%
iOS 40.5%

Generated by 🚫 dangerJS against 3d8a3aa

Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👌 Let's merge this.

I think now we need to run this across our stale PRs ?

Base automatically changed from dev to master November 14, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants