Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): UIManagerModule Fix for Bridgeless #1236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arushikesarwani94
Copy link

@arushikesarwani94 arushikesarwani94 commented Jun 14, 2024

Description of the change

https://github.com/Instabug/Instabug-React-Native/blob/master/android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java#L925

will fail in Bridgeless mode React Native 0.74 on Android since this returns null in Bridgeless

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java#L600-L606

How

Implemented fallback in Bridgeless to UIManagerHelper

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@arushikesarwani94 arushikesarwani94 marked this pull request as ready for review June 14, 2024 18:02
@arushikesarwani94
Copy link
Author

cc: @ahmedAlaaInstabug for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant