New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[F812] Warn when list comprehension redefines a name #276

Open

ansley wants to merge 2 commits into gh/"ansley"/6/base from gh/"ansley"/6/head

Commits on Mar 8, 2023

[F812] Warn when list comprehension redefines a name

This lint rule is probably in Flake8 to prevent elements from leaking
out of the comprehension scope, but the behavior was fixed in Python3.
I worry such a strict lint rule will cause more problems than it solves,
considering we use Python 3.10 at Meta. Perhaps we should consider
disabling this rule by default.

[ghstack-poisoned]

ansley committed Mar 8, 2023

Commits on Mar 16, 2023

Update on "[F812] Warn when list comprehension redefines a name"

This lint rule is probably in Flake8 to prevent elements from leaking
out of the comprehension scope, but the behavior was fixed in Python3.
I worry such a strict lint rule will cause more problems than it solves,
considering we use Python 3.10 at Meta. Perhaps we should consider
disabling this rule by default.

[ghstack-poisoned]

ansley committed Mar 16, 2023