Skip to content

Fix destructor error #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faberga merged 1 commit into from
May 15, 2025
Merged

Fix destructor error #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,15 @@ if (NOT HEXL_FPGA_COMPATIBILITY)
set(HEXL_FPGA_COMPATIBILITY "0" CACHE INTERNAL "Set FPGA compatibility mask" FORCE)
endif()

# Get the current working branch
execute_process(
COMMAND git rev-parse --abbrev-ref HEAD
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
OUTPUT_VARIABLE GIT_BRANCH
OUTPUT_STRIP_TRAILING_WHITESPACE
)

message(STATUS "HEXL BRANCH: ${GIT_BRANCH}")
message(STATUS "CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
message(STATUS "CMAKE_C_COMPILER: ${CMAKE_C_COMPILER}")
message(STATUS "CMAKE_CXX_COMPILER: ${CMAKE_CXX_COMPILER}")
Expand Down
2 changes: 1 addition & 1 deletion hexl/include/hexl/ntt/ntt.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class NTT {
NTT() = default;

/// @brief Destructs the NTT object
~NTT() = default;
~NTT();

/// @brief Initializes an NTT object with degree \p degree and modulus \p q.
/// @param[in] degree also known as N. Size of the NTT transform. Must be a
Expand Down
2 changes: 2 additions & 0 deletions hexl/ntt/ntt-internal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ NTT::NTT(uint64_t degree, uint64_t q, uint64_t root_of_unity,
NTT::NTT(uint64_t degree, uint64_t q, std::shared_ptr<AllocatorBase> alloc_ptr)
: NTT(degree, q, MinimalPrimitiveRoot(2 * degree, q), alloc_ptr) {}

NTT::~NTT() = default;

void NTT::ComputeRootOfUnityPowers() {
AlignedVector64<uint64_t> root_of_unity_powers(m_degree, 0, m_aligned_alloc);
AlignedVector64<uint64_t> inv_root_of_unity_powers(m_degree, 0,
Expand Down