Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dpnp.common_type implementation #2167

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

ekomarova
Copy link
Contributor

@ekomarova ekomarova commented Nov 12, 2024

This PR adds the implementation of dpnp.common_type

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ekomarova
Copy link
Contributor Author

The following 2 tests fail when check_supported_arrays_type of common_type is called

tests.third_party.cupy.test_type_routines.TestCommonType.test_common_type_single_argument
     TypeError: An array must be any of supported type, but got <class 'int'>

tests.third_party.cupy.test_type_routines.TestCommonType.test_common_type_two_arguments
     TypeError: An array must be any of supported type, but got <class 'int'>

Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2167/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant